Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds a proper documentation on how and when slips queries the APIS of urlhaus, spamhaus and cirl, in the threat_intelligence module. #500

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash commented Mar 26, 2024

Fixes Issue #499

Changes proposed

I have changed the documentation of Threat intelligence module

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash changed the title this adds a proper documetation on how and when slips queries the APIS of urlhaus, spamhaus and cirl, in the threat_intelligence module. This adds a proper documentation on how and when slips queries the APIS of urlhaus, spamhaus and cirl, in the threat_intelligence module. Mar 26, 2024
Copy link
Collaborator

@eldraco eldraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sekhar-Kumar-Dash im not sure where the 'CIRCL.LU API.log' comes from but there is no API.log file, and also it is not obtained from Zeek. Not sure what you wanted to say, but can you fix?
Also please put the names of the servies queried as headings not normal text. Thanks

@Sekhar-Kumar-Dash
Copy link
Contributor Author

@Sekhar-Kumar-Dash im not sure where the 'CIRCL.LU API.log' comes from but there is no API.log file, and also it is not obtained from Zeek. Not sure what you wanted to say, but can you fix? Also please put the names of the servies queried as headings not normal text. Thanks

@eldraco Sorry, I have mistaken it with something else. I have made the fixes, please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants