Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests to test_slips_utils.py #524

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

Fixes Issue #523

Changes proposed

This pull request adds more tests for slips_utils.py

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Copy link
Collaborator

@AlyaGomaa AlyaGomaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Sekhar-Kumar-Dash i will re-review your PR after using @pytest.mark.parametrize everywhere,
you can use it whenever you start calling the same function you're testing more than once in the same unit tests with different params.

you can read more about it here
https://docs.pytest.org/en/7.1.x/how-to/parametrize.html#pytest-mark-parametrize-parametrizing-test-functions

Thanks for the hard work! we appreciate it.

tests/test_slips_utils.py Outdated Show resolved Hide resolved
tests/test_slips_utils.py Outdated Show resolved Hide resolved
@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Apr 17, 2024

hey @Sekhar-Kumar-Dash i will re-review your PR after using @pytest.mark.parametrize everywhere, you can use it whenever you start calling the same function you're testing more than once in the same unit tests with different params.

you can read more about it here https://docs.pytest.org/en/7.1.x/how-to/parametrize.html#pytest-mark-parametrize-parametrizing-test-functions

Thanks for the hard work! we appreciate it.

Hey @AlyaGomaa , Thanks for the suggestion , I will use parametrize and update this PR soon. I will also keep this in mind for future unit test PRs. First, I thought you wanted me to use parametrize for each test you commented, but now I understand that you want me to combine similar tests into one using parametrize. Please ignore my recent changes to this PR

@Sekhar-Kumar-Dash
Copy link
Contributor Author

hey @AlyaGomaa just updated the PR please take a look

@AlyaGomaa
Copy link
Collaborator

Hello @Sekhar-Kumar-Dash the unit tests for slips_utils.py are failing

@Sekhar-Kumar-Dash
Copy link
Contributor Author

hey @AlyaGomaa I was not getting these errors locally, but I fixed it by looking into the assertion errors
please take a look

@Sekhar-Kumar-Dash
Copy link
Contributor Author

hey @AlyaGomaa I made the required changes please review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants