-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more tests to test_slips_utils.py #524
base: develop
Are you sure you want to change the base?
Added more tests to test_slips_utils.py #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Sekhar-Kumar-Dash i will re-review your PR after using @pytest.mark.parametrize everywhere,
you can use it whenever you start calling the same function you're testing more than once in the same unit tests with different params.
you can read more about it here
https://docs.pytest.org/en/7.1.x/how-to/parametrize.html#pytest-mark-parametrize-parametrizing-test-functions
Thanks for the hard work! we appreciate it.
…ts test_slips_utils.py
Hey @AlyaGomaa , Thanks for the suggestion , I will use parametrize and update this PR soon. I will also keep this in mind for future unit test PRs. First, I thought you wanted me to use parametrize for each test you commented, but now I understand that you want me to combine similar tests into one using parametrize. Please ignore my recent changes to this PR |
hey @AlyaGomaa just updated the PR please take a look |
Hello @Sekhar-Kumar-Dash the unit tests for slips_utils.py are failing |
hey @AlyaGomaa I was not getting these errors locally, but I fixed it by looking into the assertion errors |
# Conflicts: # modules/threat_intelligence/threat_intelligence.py
hey @AlyaGomaa I made the required changes please review it |
Fixes Issue #523
Changes proposed
This pull request adds more tests for slips_utils.py
Check List (Check all the applicable boxes)