Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and added more tests to test_flow_handler.py #563

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

Fixes Issue #562

Changes proposed

This pull request adds more tests for flow_handler.py

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Copy link
Collaborator

@AlyaGomaa AlyaGomaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Sekhar-Kumar-Dash
I see your code still has the issue of long lines. max line chars should be 78 chars.
Can you please configure your IDE to user PEP8 style guide?
Thanks for your PR! i will re-review again when you fix all calls to cassert_called_with() with ANY parameter.

@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Apr 24, 2024

Hello @Sekhar-Kumar-Dash I see your code still has the issue of long lines. max line chars should be 78 chars. Can you please configure your IDE to user PEP8 style guide? Thanks for your PR! i will re-review again when you fix all calls to cassert_called_with() with ANY parameter.

hey @AlyaGomaa PYcharm is showing just one PEP8 style error
image
Are you getting more errors in your IDE? Anyway, I will further shorten the long lines.

@Sekhar-Kumar-Dash
Copy link
Contributor Author

@AlyaGomaa I have just updated the pull request, and I used asdict as it was throwing an assertion error when using dict. Please check the code.

@AlyaGomaa
Copy link
Collaborator

Hello @Sekhar-Kumar-Dash. checkingg

@AlyaGomaa AlyaGomaa merged commit 876d44b into stratosphereips:develop Apr 29, 2024
1 check passed
@AlyaGomaa
Copy link
Collaborator

Hey @Sekhar-Kumar-Dash thanks for the awesome PR! we appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants