-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated and added more tests to test_flow_handler.py #563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Sekhar-Kumar-Dash
I see your code still has the issue of long lines. max line chars should be 78 chars.
Can you please configure your IDE to user PEP8 style guide?
Thanks for your PR! i will re-review again when you fix all calls to cassert_called_with() with ANY parameter.
hey @AlyaGomaa PYcharm is showing just one PEP8 style error |
@AlyaGomaa I have just updated the pull request, and I used asdict as it was throwing an assertion error when using dict. Please check the code. |
Hello @Sekhar-Kumar-Dash. checkingg |
Hey @Sekhar-Kumar-Dash thanks for the awesome PR! we appreciate it! |
Fixes Issue #562
Changes proposed
This pull request adds more tests for flow_handler.py
Check List (Check all the applicable boxes)