Added more tests to test_whitelist.py #565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts with tensorflow
…unning, either using -S or -D
… current daemon to run it
…y cant be used with the daemon
…aemon's or the Main() class'
|
Hey @AlyaGomaa , it is saying the process is canceled. I could not get it. Did it happen because of errors in the code? |
…k_why_redis_config_file_is_modified_each_run only overwrite redis config file when the dafault options are modified
Updated and added more tests to test_flow_handler.py
|
@Sekhar-Kumar-Dash i don't know that was weird, but no this is not coming from your code. i restarted CI and we'll see |
…t_the_used_cmd_in_metadata Add the cmd used to metadata/info
…k_exporting_of_sensitive_evidence Fix exporting of sensitive evidence
AlyaGomaa
reviewed
May 22, 2024
There was a problem hiding this comment.
hey @Sekhar-Kumar-Dash thanks for all the hard work!!
i left some comments, and i will wait for you to fix them and re-review the PR.
again thanks for making Slips better :)!
|
hey @AlyaGomaa Just updated the test file please check |
AlyaGomaa
added
Waiting for CI to pass
and removed
Awaiting Contributor Update
Waiting for CI to pass
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #564
This pull request adds more tests for whitelist.py