-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not compatable with base model in ci 4.5 #52
base: develop
Are you sure you want to change the base?
Fix not compatable with base model in ci 4.5 #52
Conversation
@MGatner Can this please be merged in. Struggling with quite a few projects that require this change.. |
Has anyone tested if this is backwards-compatible? We probably need to bump the CodeIgniter framework minimum version alongside this change. |
I only encountered this after updating to v4.5.0 so yeah, I believe this should bump the min ver to ^4.5. |
any updates with the pr? |
I don't use this library myself anymore except in locked legacy projects. Honestly the experience of working with an ORM-ish in CI4 pushed me in the opposite direction, and I now favor a very bespoke Repository approach. I am happy to maintain this library but it's harder to do things like backwards-compatibility testing. For this PR specifically I think we need to lock the framework dependency so we don't mess up older projects. If @seunex17 is not available to do that today/tomorrow then I can handle it post-merge. |
Okay! @MGatner am going to address this in the next hour. |
@MGatner please have a look and let me know it that okay to move on. |
After upgrade to Codeigniter version 4.5 it broken while using the ModelTrait look like Codeigniter changed thier findAll() method.
i update
$limit = 0
to$limit = null
CI4 now use null as default value to limit instead of 0