Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature dictionary update] Add various missing features from mach2 repo #120

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Pinguin2001
Copy link

This PR adds 86 missing features to FeatureDictionary, all of which are present in 25997

@Pinguin2001 Pinguin2001 changed the title Feature dictionary update [Feature dictionary update] Add various missing features from mach2 repo Nov 18, 2023
@thebookisclosed
Copy link
Owner

The IDs aren't ordered in their usual fashion, it should be from highest to lowest globally, plus the few high ID outliers stuck at the bottom.
I'm also quite certain that more than 86 features had to have popped up since the last dictionary update 6 months ago and I don't want to push a partial update.

@Pinguin2001
Copy link
Author

Pinguin2001 commented Nov 18, 2023

Okay, yes, there are more which have been added.
I will create a new feature dictionary with all IDs from all builds and sort them accordingly

@Pinguin2001
Copy link
Author

This feature dictionary should contain all IDs from the mach2 feature repo up until Build 25997
In addition I sorted the IDs accordingly
I hope this helps!

@Pinguin2001
Copy link
Author

Pinguin2001 commented Nov 18, 2023

image

image

Since the dictionary hasn't been updated in a really long time, features have been renamed, thus causing duplication problems. What should I do with them?

@thebookisclosed
Copy link
Owner

Unfortunately the latest commit is still problematic, features like USB4SettingsDomainsViewer occur multiple times with different IDs
Maintaining the list is not a fun task, if you are fine with waiting a few days more I'll make the final adjustments myself.

@Pinguin2001
Copy link
Author

Pinguin2001 commented Nov 22, 2023

That would be great.
These features toggle the same underlying functionality, but their IDs differ in different builds.
In the future ill keep an eye on added features in the mach2 repo and once I have time, Ill add them to the dictionary.
Updating an old list is much more time consuming than adding a few new features every build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants