Bring biometric back to fix fingerprint auth on some ROMs. #7577
Conversation
Kissycat
changed the title
|
We host authentication to systemui, if your device's systemui does not support biometrics, then neither does magisk. |
|
In fact, I don't think it's possible to have a device that doesn't support device credential. Can you screen record to show us what is happening on your device? |
Recorder_20231201204752.mp4
Sure, here it is, meizu flyme, only support pin with device credential... |
|
I understand, your systemui does not allow our authentication requests to use biometrics. |
Yes, actually not only your magisk's , I come across same situation with chrome web app, but other app like Play store, 2FAS Auth, ice Box and anything else, my biometric auth works well. Even with magisk, it works correctly before commit 678c07f. |
|
@vvb2060 In this case, can this request be merged? |
Kissycat
force-pushed
the
master
branch
3 times, most recently
from
5061d94
to
8c2e0e6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Kissycat
force-pushed
the
master
branch
4 times, most recently
from
52c0926
to
19c5333
Compare
topjohnwu
force-pushed
the
master
branch
4 times, most recently
from
e46cdcd
to
8e7186e
Compare
| if (prefs.getBoolean(SU_FINGERPRINT, false)) | ||
| suBiometric = true | ||
| remove(SU_FINGERPRINT) |
There was a problem hiding this comment.
Maybe we can just remove all stuffs about the SU_FINGERPRINT field, since its functionality has been removed in b29f0ca which is 5 years ago?
| @@ -173,6 +173,9 @@ | |||
| <string name="settings_su_auth_title">身份验证</string> | |||
| <string name="settings_su_auth_summary">对超级用户请求验证身份</string> | |||
| <string name="settings_su_auth_insecure">设备未配置验证方式</string> | |||
| <string name="settings_biometric_disabled">禁用验证</string> | |||
| <string name="settings_biometric_system">系统提供</string> | |||
| <string name="settings_biometric_magisk">Magisk提供</string> | |||
There was a problem hiding this comment.
| <string name="settings_biometric_magisk">Magisk提供</string> | |
| <string name="settings_biometric_magisk">Magisk 提供</string> |
| <string name="settings_su_auth_insecure">裝置未配備驗證方式</string> | ||
| <string name="settings_biometric_disabled">禁用驗證</string> | ||
| <string name="settings_biometric_system">系統提供</string> | ||
| <string name="settings_biometric_magisk">Magisk提供</string> |
There was a problem hiding this comment.
| <string name="settings_biometric_magisk">Magisk提供</string> | |
| <string name="settings_biometric_magisk">Magisk 提供</string> |
topjohnwu
force-pushed
the
master
branch
4 times, most recently
from
ec54aed
to
f61827c
Compare
Not every ROMs support device credential, to support more devices add magisk biometric back please..
Tested.