Clean up unrooted boot patching log errors #7047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cp: can't preserve ownership of 'busybox': Operation not permitted cp: can't preserve ownership of 'magisk32': Operation not permitted cp: can't preserve ownership of 'magisk64': Operation not permitted cp: can't preserve ownership of 'magiskboot': Operation not permitted cp: can't preserve ownership of 'magiskinit': Operation not permitted cp: can't preserve ownership of 'magiskpolicy': Operation not permitted remove call since cp_readlink shouldn't be necessary with installDir getting cleaned up regularly
osm0sis
force-pushed
the
fix/install-errors
branch
from
d8b9404
to
7a51b9c
Compare
vvb2060
reviewed
Jun 5, 2023
| srcBoot.delete() | ||
| "cp_readlink $installDir".sh() |
There was a problem hiding this comment.
Why though? It produces the errors in the commit message when run on an unrooted device, the actual .img patching happens before the call/errors and all works fine, and the app is continually deleting the internal installDir to start fresh anyway.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
osm0sis
force-pushed
the
fix/install-errors
branch
2 times, most recently
from
c5cd392
to
03b5d16
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
osm0sis
force-pushed
the
fix/install-errors
branch
from
03b5d16
to
9c900a2
Compare
osm0sis
force-pushed
the
fix/install-errors
branch
from
9c900a2
to
00daad4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
osm0sis
changed the title
osm0sis
changed the title
osm0sis
force-pushed
the
fix/install-errors
branch
from
00daad4
to
43bd7cf
Compare
|
I see the new built-in avb 1.0 signing adds a new error/warning to the install logs on all AVB2 (VBMETA) signed imgs, rooted and unrooted: But I don't think I can figure out how to fix that one. |
topjohnwu
force-pushed
the
master
branch
3 times, most recently
from
e46cdcd
to
8e7186e
Compare
topjohnwu
force-pushed
the
master
branch
4 times, most recently
from
ec54aed
to
f61827c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up unrooted boot patching cp errors in log
remove call since cp_readlink shouldn't be necessary with installDir getting cleaned up regularly
cp: can't preserve ownership of 'busybox': Operation not permitted
cp: can't preserve ownership of 'magisk32': Operation not permitted
cp: can't preserve ownership of 'magisk64': Operation not permitted
cp: can't preserve ownership of 'magiskboot': Operation not permitted
cp: can't preserve ownership of 'magiskinit': Operation not permitted
cp: can't preserve ownership of 'magiskpolicy': Operation not permitted
See: magisk_install_log_2023-06-04T20.03.33.log