Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch IllegalArgumentException in case the zip is malformed #7986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

canyie
Copy link
Collaborator

@canyie canyie commented Apr 12, 2024

https://appcenter.ms/users/vvb2060/apps/Magisk/crashes/errors/475114485u/overview

java.lang.IllegalArgumentException: MALFORMED[1]
java.util.zip.ZipCoder.toString ZipCoder.java:65
java.util.zip.ZipInputStream.readLOC ZipInputStream.java:319
java.util.zip.ZipInputStream.getNextEntry ZipInputStream.java:125
com.topjohnwu.magisk.core.tasks.MagiskInstallImpl.processZip MagiskInstallImpl.java
com.topjohnwu.magisk.core.tasks.MagiskInstallImpl.handleFile MagiskInstallImpl.java
com.topjohnwu.magisk.core.tasks.MagiskInstallImpl.patchFile MagiskInstallImpl.java
com.topjohnwu.magisk.core.tasks.MagiskInstaller$Patch.operations MagiskInstaller.java
com.topjohnwu.magisk.core.tasks.MagiskInstallImpl$exec$result$1.invokeSuspend MagiskInstallImpl.java
kotlin.coroutines.jvm.internal.BaseContinuationImpl.u BaseContinuationImpl.java:6
kotlinx.coroutines.DispatchedTask.run DispatchedTask.java
kotlinx.coroutines.internal.LimitedDispatcher$Worker.run LimitedDispatcher.java
androidx.appcompat.widget.ActionMenuPresenter$OpenOverflowRunnable.run$bridge ActionMenuPresenter.java
kotlinx.coroutines.scheduling.TaskImpl.run TaskImpl.java
kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely CoroutineScheduler.java
kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask CoroutineScheduler.java
kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker CoroutineScheduler.java
kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run CoroutineScheduler.java

@topjohnwu topjohnwu force-pushed the master branch 4 times, most recently from ec54aed to f61827c Compare May 9, 2024 09:19
@vvb2060
Copy link
Collaborator

vvb2060 commented May 20, 2024

The full factory image is too large, I think we should remove this feature and pull specific partition from the network instead. https://github.com/5ec1cff/payload-dumper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants