Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect instruction of resetprop #8037

Closed
wants to merge 2 commits into from

Conversation

aviraxp
Copy link
Contributor

@aviraxp aviraxp commented May 10, 2024

This instruction is wrong because the prop doesn't exist when boot is not completed.

This instruction is wrong because the prop doesn't exist
when boot is not completed.
@aviraxp
Copy link
Contributor Author

aviraxp commented May 10, 2024

cc @yujincheng08

@yujincheng08
Copy link
Collaborator

I intentionally didnt write it in a while-loop for non-existent props, because not all the people like the sleep 1.

@vvb2060
Copy link
Collaborator

vvb2060 commented May 10, 2024

Why not use this?

while [ "$(getprop sys.boot_completed)" != "1" ]; do
  sleep 1
done

Does resetprop -w have any advantages over it? It is more compatible than resetprop -w

@dxkf177

This comment was marked as spam.

docs/guides.md Show resolved Hide resolved
docs/guides.md Show resolved Hide resolved
@osm0sis osm0sis requested a review from dxkf177 May 14, 2024 16:54
@osm0sis

This comment was marked as off-topic.

@osm0sis osm0sis removed the request for review from dxkf177 May 14, 2024 16:55
@aviraxp aviraxp closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants