Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safebrowsing fix for mac and win & Disable FedCM functionality #2872

Merged
merged 2 commits into from
May 21, 2024
Merged

Safebrowsing fix for mac and win & Disable FedCM functionality #2872

merged 2 commits into from
May 21, 2024

Conversation

Ahrotahn
Copy link
Contributor

This PR contains two commits with small bugfixes:

  • A fix for the safebrowsing patch for mac and win. The enterprise cert store is not built, so these functions are not available.
  • Disable the creation of the FedCM implementation. Some users are able to trigger this, so lets ensure it is not able to function. There's also a change to remove the interface option in the UI removal patch. Fixes Google sign-in prompt shows up on some websites #2869

@Ahrotahn Ahrotahn requested a review from a team as a code owner May 20, 2024 13:30
@Ahrotahn Ahrotahn merged commit 78ebf88 into ungoogled-software:master May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PF4Public PF4Public PF4Public approved these changes

@networkException networkException networkException approved these changes

@clickot clickot clickot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google sign-in prompt shows up on some websites
4 participants
@Ahrotahn @PF4Public @networkException @clickot