Feat/UI feedback : Visual + console feedback for failed postman translated imports #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 13, 2024 14:32
…nslations with stats and details
…ng import location
lohxt1
reviewed
May 16, 2024
packages/bruno-app/src/utils/importers/translators/postman_translation.js
Outdated
Show resolved
Hide resolved
lohxt1
reviewed
May 16, 2024
| @@ -12,14 +12,16 @@ const replacements = { | |||
| 'pm\\.response\\.json\\(': 'res.getBody(', | |||
| 'pm\\.expect\\(': 'expect(', | |||
| 'pm\\.environment\\.has\\(([^)]+)\\)': 'bru.getEnvVar($1) !== undefined && bru.getEnvVar($1) !== null' | |||
|
Thanks for your comments I fixed that in the latest commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following changes from #2031 : improved ui feedbacks to display failed translations while importing a postman collection into bruno
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.