Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting epoch loop restarting flag in LearningRateFinder #19819

Merged

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Apr 25, 2024

What does this PR do?

lr_finder does not reset fit_loop.epoch_loop.restarting to False which causes the validation check to trigger validation on the first advance() call because of this check.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

馃摎 Documentation preview 馃摎: https://pytorch-lightning--19819.org.readthedocs.build/en/19819/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 25, 2024
@clumsy
Copy link
Contributor Author

clumsy commented May 1, 2024

Could you please check this fix @awaelchli , @carmocca ?

@Borda Borda changed the title fix: lr_finder epoch loop restarting flag (#19818) fix: lr_finder epoch loop restarting flag May 22, 2024
@mergify mergify bot removed the has conflicts label May 22, 2024
@awaelchli awaelchli added bug Something isn't working tuner community This PR is from the community labels Jun 7, 2024
@awaelchli awaelchli added this to the 2.3 milestone Jun 7, 2024
@awaelchli awaelchli changed the title fix: lr_finder epoch loop restarting flag Fix resetting epoch loop restarting flag in LearningRateFinder Jun 7, 2024
@awaelchli awaelchli merged commit 06ea3a0 into Lightning-AI:master Jun 7, 2024
90 checks passed
@awaelchli
Copy link
Member

Thank you for the fix @clumsy, very nice!
It looks like the batch size finder would need the same fix as well. Are you interested to investigate it as well?

@clumsy
Copy link
Contributor Author

clumsy commented Jun 7, 2024

Interesting, batch_size_finder actually worked for me but I can check and make the change, sure.

There was a more critical bug for LR finder, I'm afraid, @awaelchli: #19814

@clumsy clumsy deleted the fix/lr_finder_epoch_loop_restarting branch June 7, 2024 16:01
@clumsy
Copy link
Contributor Author

clumsy commented Jun 7, 2024

This flag reset is seem to be in place for batch_size_finder here, @awaelchli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community pl Generic label for PyTorch Lightning package tuner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants