Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RSS module #715

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New RSS module #715

wants to merge 2 commits into from

Conversation

lightglitch
Copy link
Contributor

@lightglitch lightglitch commented Oct 14, 2022

Hi, the module almost done. Only one issue:

  • One issue about reloading that I need your help
    The issue is when we do a pull to refresh in the results page, when we go back (pop) I want to update the feed tile in the feeds page but I was unable to force that redraw on pop. All ideas are welcome.

Any feedback is welcome

@JagandeepBrar
Copy link
Owner

Hey @lightglitch, thanks for this PR but at this time major feature merges are blocked until some additional substantial changes to the architecture are complete. This will likely be the case for the course of the next 4-6 months until they have been completed, as the next big architecture transition is to use Riverpod instead of Provider for the state management.

For the time being I will keep the PR open and of course you are free to use your custom build but it won't be merged in for the foreseeable future.

@JagandeepBrar JagandeepBrar added the deferred Things that need to wait for something else label Oct 20, 2022
@lightglitch
Copy link
Contributor Author

Just looked at Riverpod and probably would solve my refresh issue.
I will use those 4-6 months to start other modules that I would use integrated in Luna, after that some refactoring to be merge.
Keep up the good work an thx for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deferred Things that need to wait for something else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants