-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new features, fix .env setup, fix permissions and UID conflicts #50
base: main
Are you sure you want to change the base?
Conversation
automatic timezone detection
and updating the containers
also use a previously unused function to clean up code
new .env sample, fixed setup
It failed the docker-compose check because there is no longer a docker-compose file but just a sample. It wouldn't work anyway now since |
You could add something like a "sample" |
Updated auto-check workflow to also copy docker-compose sample file, updated syntax to docker compose without "-"
I've addressed all complaints from #49 and some more.
Changes:
main.py
(it just reads from /etc/timezone),.env
anddocker-compose.yml
samples. This also gives the end user the ability to customize container UIDs for manual installs. I also changed the provided compose file to a.sample
, so it's more like the .env sample and the user will always have a copy of the original even if overwritten by the python script.version
fromdocker-compose.yml
so compose v2 doesn't complain about it. Also added a note to README.I tried to keep my commit history as clean as possible so I hope reviewing this will be easy, although I did make quite a lot of changes. I did some testing and everything should work perfectly now.