Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the log database #9110

Closed
1 task done
onedr0p opened this issue Aug 31, 2023 · 5 comments · Fixed by #9943
Closed
1 task done

Allow disabling the log database #9110

onedr0p opened this issue Aug 31, 2023 · 5 comments · Fixed by #9943
Labels
Area: Database Issue is related to the database sonarr upstream Issue can / could be fixed by using Sonarr's code Type: Enhancement Current situation is suboptimal and could use improvement. Type: Feature Request Issue is a feature request.

Comments

@onedr0p
Copy link
Contributor

onedr0p commented Aug 31, 2023

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Is your feature request related to a problem? Please describe

I am using Radarr with Postgres and it's a bit inconvenient to have to have 2 databases per instance of Radarr. In my setup I have logs via stdout which are also going to a log aggregator (Loki), Radarr also writes the logs to disk and writes logs to another database. I don't see the need to have 3 places for the logs.

Describe the solution you'd like

It would be awesome if there was a way in the config.xml to disable the log database completely and disable any feature in the app that relies on it.

Describe alternatives you've considered

There really isn't any alternative.

Anything else?

N/A

@onedr0p onedr0p added Status: Needs Triage New Issue needing triage Type: Feature Request Issue is a feature request. labels Aug 31, 2023
@onedr0p
Copy link
Contributor Author

onedr0p commented Aug 31, 2023

Maybe this is more inclusive to the logs sqlite database too. A single option to disable the logs database no matter if you are using sqlite or postgres would be great.

@onedr0p onedr0p changed the title Allow disabling the log database when using Postgresql Allow disabling the log database Aug 31, 2023
@bakerboy448 bakerboy448 added Area: Database Issue is related to the database Type: Enhancement Current situation is suboptimal and could use improvement. labels Sep 10, 2023
@Ornias1993
Copy link

Ornias1993 commented Dec 24, 2023

Adding to this:
postgresql for logs seems like a weird choice to begin with.

But completely agree, we've gone back to sqlite for TrueCharts, partly due to forcing a second db just for logs.

@sillock1
Copy link
Contributor

The only thing I can see that is going to block this work will be the UpdateHistory table in the log database that's used by the frontend to display previously installed versions.
Any chance this table could get moved to the main database?

Otherwise there's no reason why the DI registration can't conditionally register the logging database and migration scripts based on an environment variable.

@bakerboy448
Copy link
Contributor

One day maybe / blocked upstream Sonarr/Sonarr#6743 (comment)

@bakerboy448 bakerboy448 added sonarr upstream Issue can / could be fixed by using Sonarr's code Status: Unlikely This issue is unlikely to be fixed, since it would only be useful to one person or is out of scope. Status: Maybe One Day and removed Status: Needs Triage New Issue needing triage labels Apr 21, 2024
@onedr0p
Copy link
Contributor Author

onedr0p commented Apr 21, 2024

There is already a PR open here and @sillock1 is aware that the PR should be opened/merged on Sonarr first before it trickles down to the other arrs.

@bakerboy448 bakerboy448 removed Status: Unlikely This issue is unlikely to be fixed, since it would only be useful to one person or is out of scope. Status: Maybe One Day labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Database Issue is related to the database sonarr upstream Issue can / could be fixed by using Sonarr's code Type: Enhancement Current situation is suboptimal and could use improvement. Type: Feature Request Issue is a feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants