Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Config file setting to disable log database #9943

Merged
merged 3 commits into from May 6, 2024
Merged

New: Config file setting to disable log database #9943

merged 3 commits into from May 6, 2024
+66 −8

Conversation

sillock1
Copy link
Contributor

@sillock1 sillock1 commented Apr 19, 2024 •
edited by mynameisbogdan

Database Migration

NO

Description

A lot of users aren't interesting in maintaining a 2nd database just for logs, there should be an option to disable this functionality by a flag in the config.xml.

Todos

  • Tests
  • Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)
  • Wiki Updates

Issues Fixed or Closed by this PR

@github-actions github-actions bot added the Area: API Issue is related to the API label Apr 19, 2024
@bakerboy448 bakerboy448 added Status: Unlikely This issue is unlikely to be fixed, since it would only be useful to one person or is out of scope. Type: Feature Request Issue is a feature request. Area: Database Issue is related to the database and removed Status: Unlikely This issue is unlikely to be fixed, since it would only be useful to one person or is out of scope. labels Apr 19, 2024
@mynameisbogdan
Copy link
Collaborator

Thank you for the PR, but sadly you'll need to get this into Sonarr first.

See Sonarr/Sonarr#6743 (comment) for more context.

@onedr0p onedr0p mentioned this pull request Apr 21, 2024
Closed
1 task
@sillock1 sillock1 mentioned this pull request Apr 21, 2024
Closed
1 task
@sillock1
Copy link
Contributor Author

sillock1 commented May 6, 2024

Hopefully I've done this right. I've rebased this branch and I've pulled the upstream changes from Sonarr onto this branch.
This will close this issue too
#9974

@mynameisbogdan mynameisbogdan changed the title New: toggle log database with a flag in config.xml New: Config file setting to disable log database May 6, 2024
@mynameisbogdan mynameisbogdan merged commit 086a0ad into Radarr:develop May 6, 2024
10 of 13 checks passed
@mynameisbogdan
Copy link
Collaborator

Thank you.

@mynameisbogdan mynameisbogdan removed the Type: Feature Request Issue is a feature request. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: API Issue is related to the API Area: Database Issue is related to the database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull Sonarr commit 'New: Config file setting to disable log database' Allow disabling the log database
3 participants
@sillock1 @mynameisbogdan @bakerboy448