New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IMAX Uppercase in Edition Tags #7649
Comments
This needs to be looked at more completely. Currently if you use {edition-{EDITION TAGS}} you'll get {edition-IMAX} in the file path. If you use {edition-{Edition Tags}} you'll get {edition-Imax}. Now consider 10th Anniversary. if you use {edition-{EDITION TAGS}} you'll get {edition-10TH ANNIVERSARY} but with {edition-{Edition Tags}} you get {edition-10Th Anniversary} . I think this is not correct. Even in proper case then 10TH should be '10th' and not '10Th' (with a capital 'T'). |
More investigation. Maybe something like:
which will work for English but you'd need something else if edition tags have ordinal numbers in other languages. |
Add that as a StringExtension and then update:
to be:
|
Further research suggests movie editions use exclusively English ordinal numbering so the fix above will be fine. Let me know if youd like a pull request. @Qstick |
Would you like a pull request fixing this please? |
Would love to see Andy's fix implemented. |
Ok this has been on my list of small annoyances for a long time, so I've got a fix in the works! I don't love the pattern of nested function calls (a builder pattern might be more elegant?) but it works. Would love any feedback on this implementation, then I'm happy to send in a PR. Handles strings that should always remain uppercase, e.g.
|
Discussion thread here as well: brandonscript@5582e8b#commitcomment-139616872, specifically what do we want to capitalize, and when? |
Is there an existing issue for this?
Is your feature request related to a problem? Please describe
Continuation of #7566 which was over my skis.
The IMAX (and potentially other) edition tags should be hardcoded to an all caps implementation and both replace how the edition is written in the db (usually
Imax
) as well as ignore case preference.Describe the solution you'd like
Per @Qstick an edition normalization method in the parser
Describe alternatives you've considered
A hack to just replace Imax with uppercase.
Anything else?
None
AB#3850
The text was updated successfully, but these errors were encountered: