Add lowercasing ordinals (1st, 10th) and uppercase special words (IMAX, 3D, etc.) to edition tags #9880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always lowercase ordinals (1st, 2nd, 10th, etc.) - Always uppercase special words (IMAX, 3D, SDR, HDR) in edition tags
|
Hey, I was thinking about this since you posted your suggestion on #7649 if we should do this instead ahead of saving to the database, and avoid changing capitalization when applying the custom formats. It's just a thought to debate upon, not a change request. 😄 |
|
tangent thought to this - any ideas for Extended vs Extended Cut and standardizing editions in general? |
|
@bakerboy448 I ended up doing this at one point: https://github.com/brandonscript/fylm/blob/main/fylm/fylmlib/parser.py#L310 (Would be a different ticket and PR, but I like it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
Addresses #7649
(Original goal was "Make IMAX Uppercase in Edition Tags", this now handles both lowercase (ordinals) and uppercase, as covered in the tests:
Always lowercases ordinals, except when using
[EDITION TAGS]:Always uppercases special words, except when using
[edition tags]:(And all mixed-case variants of these, e.g. imax, Imax, IMAX iMaX))
Screenshot (if UI related)
Todos
Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)Issues Fixed or Closed by this PR