New: Provide more Options to choose File Date from #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: UI
Qstick
reviewed
Dec 31, 2023
| @@ -76,6 +76,24 @@ const fileDateOptions = [ | |||
| get value() { | |||
| return translate('PhysicalReleaseDate'); | |||
| } | |||
| }, | |||
| { | |||
| key: 'cinemasOrRelease', | |||
There was a problem hiding this comment.
Wouldn't this essentially be the same as oldest in most cases? I'm struggling to see the need for all three of these. I could be missing something obvious though.
There was a problem hiding this comment.
It could be, but in rare circumstances, the release could be digital-first (or physical), and someone would like to prioritize the cinema release date. But if you want, I can remove this entry. Should I?
There was a problem hiding this comment.
One example is "The Irishman", released first on Netflix but later in selected cinemas.
There was a problem hiding this comment.
@Qstick Is there anything left I can do for you? Or are these changes ready for approval?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
I added some more options to determine which date should be used for a file.
This tries the "In Cinemas" date first, then falls back to the "Physical Release" and finally to the "Digital Release" (it is a combination of "In Cinemas" and "Physical Release"
This uses the oldest date of "In Cinemas", "Physical Release", and "Digital Release".
This uses the latest date of "In Cinemas", "Physical Release", and "Digital Release".
Todos