Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search movies with imdb/tmdb links #9754

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

HamletDuFromage
Copy link

Database Migration

NO

Description

In the movie search box, add the possibility to paste in a link to tmdb or imdb, instead of having to input imdb:id

Screenshot (if UI related)

N/A

Todos

  • Tests
  • Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)
  • Wiki Updates

Issues Fixed or Closed by this PR

N/A

@mynameisbogdan
Copy link
Collaborator

I would rather have this logic in

public object Search([FromQuery] string term)
{
var searchResults = _searchProxy.SearchForNewMovie(term);
return MapToResource(searchResults);
}

@Qstick WDYT?

@HamletDuFromage
Copy link
Author

Fair enough, I'm really not familiar with the code base (nor with C# tbh). I guess if anything this PR may serve as a feature request

@mynameisbogdan
Copy link
Collaborator

Don't sell yourself short since you did good so far 😸

But you need to make it work locally before pushing, since the CI fails at building.

@Qstick
Copy link
Member

Qstick commented Feb 11, 2024

I would rather have this logic in

public object Search([FromQuery] string term)
{
var searchResults = _searchProxy.SearchForNewMovie(term);
return MapToResource(searchResults);
}

@Qstick WDYT?

I guess it depends on if we want this to function like this for other uses that use SearchForNewMovie, or just when a lookup is called from API. I'm leaning to having it in MovieLookupController as well.

@github-actions github-actions bot added the Area: API Issue is related to the API label Feb 12, 2024
@HamletDuFromage
Copy link
Author

moved it around :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Issue is related to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants