Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: if search results empty, use GetMovieByImdbId #9810

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

New: if search results empty, use GetMovieByImdbId #9810

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c539f9f
New: if search results empty, use GetMovieByImdbId
edwinbernadus Feb 28, 2024
123d90c
Revert "New: if search results empty, use GetMovieByImdbId"
edwinbernadus Feb 29, 2024
a1816c6
move logic to controller
edwinbernadus Feb 28, 2024
62eac3e
Revert "move logic to controller"
edwinbernadus Mar 1, 2024
eb5ff08
PopulateFromImdbIfEmpty
edwinbernadus Mar 1, 2024
9d5aadf
Merge branch 'develop' into if-search-empty-findById
edwinbernadus Mar 1, 2024
45a42ad
fix logic on PopulateFromImdbIfEmpty
edwinbernadus Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/NzbDrone.Core/MetadataSource/SkyHook/SkyHookProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,27 @@ public List<Movie> SearchForNewMovie(string title)
request.SuppressHttpError = true;

var httpResponse = _httpClient.Get<List<MovieResource>>(request);
var output = httpResponse.Resource.SelectList(MapSearchResult);

return httpResponse.Resource.SelectList(MapSearchResult);
// if output is zero and format is ttXXXXXXXX, use GetMovieByImdbId
if (output.Count == 0 && title.Length == 10 && title.StartsWith("tt"))
{
var imdbid = title;
try
{
var movieLookup = GetMovieByImdbId(imdbid);
return new List<Movie>
{
new Movie { MovieMetadata = movieLookup }
};
}
catch (MovieNotFoundException)
{
return new List<Movie>();
}
}

return output;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sounds good.

Just like #9754, I would rather prefer for this to happen in the MovieLookupController.

We like documented code, but that comment can be removed. output is somewhat confusing, and I think we should check if StartsWith("tt") and ^tt\d{7,8}$.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it. i'll edit it
thank you for the review

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need advise,
should i move the main logic to SkyHookProxy.cs ?

}
catch (HttpException ex)
{
Expand Down