fix: swap trailing determiners at the end of titles #9820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Radarr#9815.\n\n Some files have their , A or , The at the end of the file to prevent alphabetical sorting clustering these titles together. This stops working when searching for files inside radarr as a cleaned title will have 'prestigethe' instead of 'theprestige'.
github-actions
bot
added
the
Area: Parser
bakerboy448
reviewed
Mar 5, 2024
| @@ -12,6 +12,7 @@ namespace NzbDrone.Common.Extensions | |||
| public static class StringExtensions | |||
| { | |||
| private static readonly Regex CamelCaseRegex = new Regex("(?<!^)[A-Z]", RegexOptions.Compiled); | |||
| private static readonly Regex TrailingDeterminerRegex = new Regex("(, The)$|(, A)$", RegexOptions.Compiled); | |||
There was a problem hiding this comment.
Suggested change
| private static readonly Regex TrailingDeterminerRegex = new Regex("(, The)$|(, A)$", RegexOptions.Compiled); | |
| private static readonly Regex TrailingArticleRegex = new Regex("(, The)$|(, A)$", RegexOptions.Compiled); |
Maybe? Food for thought
There was a problem hiding this comment.
I'm pretty impartial to the naming, but it should be consistent. Want me to change all of the occurrences from determiner to article then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
Some files have their
, Aor, Theat the end of the file to prevent alphabetical sorting clustering these titles together. This stops working when searching for files inside Radarr as a cleaned title will have 'prestigethe' instead of 'theprestige'.Seeing as
theandain the middle of a title are already filtered out and covered in a different test case I didn't write a negative test case.This is just covering English, I assume to support more languages the regex will need to be expanded.
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR