fix(web): circular imports #1415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably a temporary fix tbh.
kaiserbh
requested review from
fabricionaweb,
KyleSanderson,
s0up4200,
martylukyy and
zze0s
At the very bottom it seem like we can use getRouteApi. https://tanstack.com/router/latest/docs/framework/react/guide/code-splitting#manually-accessing-route-apis-in-other-files-with-the-routeapi-class
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
martylukyy
approved these changes
Feb 18, 2024
zze0s
reviewed
Feb 26, 2024
There was a problem hiding this comment.
Good job!
This is a lot of changes just to get rid of warnings tho.
I am however not a fan of the hardcoded route strings like /auth/authenticated-routes/filters/$filterId, feels like half of the point of the router is gone when there's hardcoded route path strings like that? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Circular Dependencies ✅ Congratulations, no circular dependency was found in your project.
@stacksmash76 ;)
Probably a temporary fix tbh.A better fix would be refactoring the whole routes.. I went through Tanstack router and should definitely follow what they suggest in particular:⚠️ Note: The following example shows how to configure routes using code, and for simplicity's sake is in a single file for this demo. While code-based generation allows you to declare many routes and even the router instance in a single file, we recommend splitting your routes into separate files for better organization and performance as your application grows.closes #1408