-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): circular imports #1415
base: develop
Are you sure you want to change the base?
Conversation
Probably a temporary fix tbh.
At the very bottom it seem like we can use getRouteApi. https://tanstack.com/router/latest/docs/framework/react/guide/code-splitting#manually-accessing-route-apis-in-other-files-with-the-routeapi-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for jumping in and fixing this! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
This is a lot of changes just to get rid of warnings tho.
I am however not a fan of the hardcoded route strings like /auth/authenticated-routes/filters/$filterId
, feels like half of the point of the router is gone when there's hardcoded route path strings like that? 🤔
• Circular Dependencies ✅ Congratulations, no circular dependency was found in your project.
@stacksmash76 ;)
Probably a temporary fix tbh.A better fix would be refactoring the whole routes.. I went through Tanstack router and should definitely follow what they suggest in particular:⚠️ Note: The following example shows how to configure routes using code, and for simplicity's sake is in a single file for this demo. While code-based generation allows you to declare many routes and even the router instance in a single file, we recommend splitting your routes into separate files for better organization and performance as your application grows.
closes #1408