refactor(http): BaseUrl handling #1298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since that's where the api endpoint is that way we set it to the root domain, we can't set it to the subfolder since the api is called directly now and not using the baseUrl.
When user for example is in `/autobrr` and hit reload it should just return the index.html.
Remove the trailing `/`, now base url is set to /autobrr aligned with other arrs.
I don't think we need separate router, but I didn't test it, so feel free to test it and see if it works without the separate router, the whole point was to make sure that it's not prefixed with baseUrl and I noticed that it was being called in the frontend `APIClients.ts`. So yea just check if it works without it then keep the old one. Also removed the index since it was zombie code not being used anywhere.
Comment on lines
+22
to
+28
| // Dynamically determine the base URL | ||
| window.BASE_URL = '{{.BaseUrl}}'; | ||
|
|
||
| // Update the base tag dynamically | ||
| const base = document.createElement('base'); | ||
| base.href = window.BASE_URL; | ||
| document.head.appendChild(base); |
There was a problem hiding this comment.
we could move this block to bellow where the window.APP.baseUrl is being defined already, than we can use that variable to base.href
base.href = window.APP.baseUrl;
zze0s
changed the title
brettpetch
reviewed
Dec 27, 2023
| @@ -62,7 +62,7 @@ func (h authHandler) login(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| h.cookieStore.Options.HttpOnly = true | |||
| h.cookieStore.Options.SameSite = http.SameSiteLaxMode | |||
| h.cookieStore.Options.Path = h.config.BaseURL | |||
| h.cookieStore.Options.Path = "/" | |||
There was a problem hiding this comment.
I don't think we should be setting cookieStore to /. A significant amount of our users host on baseurls and this will allow other applications on the machine to read the cookie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully closes #1166, I am sure this is a breaking change so do test it thoroughly.
By breaking change I mean maybe proxy level, people might have to update their proxy configuration.
I only tested it with caddy with below config
sse seem to work fine and not seeing any errors.
Anyway do test it.