chore(lint): reinstate eslint rules #1327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martylukyy
added
web
dependencies
substitute single quotes with double quotes in .eslintrc.cjs
# Conflicts: # web/package.json # web/pnpm-lock.yaml
|
@martylukyy Great work on reinstating the ESLint rules! To further enhance code consistency, have you considered integrating Prettier as well? It could streamline formatting and work alongside ESLint, handling its configurations. This could help in reducing style-related errors and maintaining code readability. Open to discussing how they could best be configured to complement each other! |
s0up4200
previously approved these changes
Jan 9, 2024
kaiserbh
approved these changes
Feb 18, 2024
fabricionaweb
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we merged PR #1276 we began with a default
.eslintrc.cjsI looked at some of our old rules from:
https://github.com/autobrr/autobrr/blob/17e97201fdfbe892f9299dcb1333514d1643a06b/web/.eslintrc.js
and migrated the deprecated rules to the new ESLint Stylistic package.
https://eslint.style/
Merging this PR will create quite a few ESLint error and warnings.
Some of those will be resolved in seperate PRs so that we don't end up with a mega PR again.
I listened and took notes to quite a few discussions about our code style in the past times.
These new ESLint rules should solve some the controversial discussions.
If someone wants to discuss changes or further additions - here and now is the time! 馃槃