-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebAPI: Add "private" filter for 'info' endpoint #20833
base: master
Are you sure you want to change the base?
WebAPI: Add "private" filter for 'info' endpoint #20833
Conversation
31955e6
to
37ee324
Compare
37ee324
to
44e71b0
Compare
@glassez Thanks having included this on milestone 5.0, and for having reviewed the code. I was not able to figure out how to test whether the feature works properly. Just wanted to check if you had a chance to test if it actually works? Many thanks |
@glassez - quick question, do I need to do anything here to get this merged? |
At least it should be confirmed by someone from the team (or maybe by couple of other people) that it works as intended. |
Thank you for the fast response. I unfortunately did not figure out how to build a docker image from the code so that I could test it myself. Did you test it on your end by any chance? If so, did it work? Looking forward for the other people to test it (guess that is done via qbittorrent/web-developers ?) |
Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
@Chocobo1 - many thanks for your review. I incorporated your changes. Regarding renaming: I am not sure I understand your suggestion to rename the "isPrivate" to "private" in the various places. Since the flag that is returned currently in the properties is called "isPrivate", I feel it makes sense to keep calling it like this, rather than changing to "private". What was your thinking when suggesting the rename? In terms of functionality, did the feature work for you as expected? |
Thx for the commit, @glassez , much appreciated |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
a2ae231
to
3eb56df
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
…and torrentfilter.cpp
56f4790
to
69a2577
Compare
@ManiMatter
|
done |
It is already possible to filter the "info" response by hashes, status, tag, category.
Since the "isPrivate" flag has been added in #20686, it would be nice if it was possible to also pre-filter the response by this attribute.
I have - to the best of my abilities - implemented the code, but it is at the edge of my skills and I would appreciate your review.
The failed checks seem macOS related and affecting any PRs right now, thus not triggered by the changes I propose here