-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve structure of AddNewTorrentDialog code #20848
Conversation
@qbittorrent/bug-handlers |
src/gui/addnewtorrentdialog.ui
Outdated
<item> | ||
<widget class="QCheckBox" name="checkBoxNeverShow"> | ||
<property name="text"> | ||
<string>Never show again</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When was this functionality removed (doesn't work in master, works in 4.6.4) and why isn't it in the change log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When was this functionality removed (doesn't work in master, works in 4.6.4) and why isn't it in the change log?
@thalieht
Good catch!
It was unintentionally added into this PR.
The fact is that it was originally a preliminary refactoring before other (deeper) changes. But they are still stuck indefinitely, so I decided to merge this commit separately. However, this part of changes doesn't really make sense yet, so I reverted it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well i still don't know if it's meant to be removed eventually but right now it still doesn't work, this is not present in master:
qBittorrent/src/gui/addnewtorrentdialog.cpp
Lines 490 to 493 in 21143a9
void AddNewTorrentDialog::setEnabled(const bool value) | |
{ | |
settings()->storeValue(KEY_ENABLED, value); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it looks like you discovered a regression of #19355 along the way.
Fixed.
b1fb007
to
a914a6e
Compare
Code restructuring that separates the basic logic from the logic that depends on the parameters and properties of the torrent being added.