This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
Auth bypass #46
Open
Auth bypass #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that your service definition includes an auth bypass vulnerability.
By exposing the backend service ports in your compose file it is possible to bypass the reverse proxy which in turn allows anyone to bypass the authentication layer you've set up.
For example I assume you meant for radarr to only be available via radarr.example.org. However by default the service is also available via example.org:7878 without any authentication.
In this PR I've removed most of the port exposures except for tcp/32400 since plex uses their own authentication layer. While it can be routed through traefik it is not necessary. I'm not sure about the other ports but in my experience tcp/32400 is the only one needed for it to work.
As far as my tests go this doesn't break any functionality of the app but I'm not running all of the services myself, so feel free to dive a little deeper :)
Cheers