-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Built-in-webrtc #2786
feat: Built-in-webrtc #2786
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@thaunknown/simple-peer@9.12.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked as expected on all local testing, both to https://instant.webtorrent.dev and between two NodeJS WebTorrent peers via WebRTC. This looks good to me!
# [2.3.0](v2.2.2...v2.3.0) (2024-05-23) ### Features * Built-in-webrtc ([#2786](#2786)) ([c693f9e](c693f9e))
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi, I believe this breaks |
verify it, because an "I believe" doesn't cut it, there's no reason for it to not support webrtc |
I can't remember where it was being used, but I remember Edit: I tried again and WebRTC is working. I'm not sure when node-webrtc was removed, but I guess it was. |
this doesn't use node-webrtc |
This works as expected on ARM, the new library being used for WebRTC supports ARM devices.
|
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
webrtc is now built in, this deprecates webtorrent-hybrid
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?