Skip to content

Conversation

pengmai
Copy link
Member

@pengmai pengmai commented Oct 9, 2024

No description provided.

@pengmai pengmai requested review from wsmoses and ftynse October 9, 2024 16:08
@pengmai pengmai marked this pull request as ready for review October 9, 2024 16:11
Copy link
Collaborator

@ftynse ftynse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable overall, please give @wsmoses a chance to take a look

Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a relevant test be added to make sure it doesn’t break?

@pengmai pengmai force-pushed the jmp/summary-activity branch 3 times, most recently from b40b4d1 to 2e0a794 Compare October 11, 2024 21:39
@wsmoses
Copy link
Member

wsmoses commented Oct 14, 2024

@pengmai I'm going to merge for now to avoid rebase issues, but comments above should be addressed subsequently

@pengmai pengmai force-pushed the jmp/summary-activity branch 2 times, most recently from d036184 to 63c2079 Compare October 31, 2024 19:17
@pengmai pengmai force-pushed the jmp/summary-activity branch from 63c2079 to 6bf3dcd Compare June 9, 2025 18:19
@pengmai pengmai force-pushed the jmp/summary-activity branch from 6bf3dcd to c61bb1f Compare June 9, 2025 18:57
@pengmai pengmai enabled auto-merge June 10, 2025 16:00
@wsmoses wsmoses disabled auto-merge June 17, 2025 15:32
@wsmoses wsmoses merged commit 31d9676 into main Jun 17, 2025
20 of 27 checks passed
@wsmoses wsmoses deleted the jmp/summary-activity branch June 17, 2025 15:32
gbaraldi pushed a commit to gbaraldi/Enzyme that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants