drop scala 2.11 and remove paranamer dependency #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might need to undo this - #505 happened the last time I removed paranamer. |
|
I looked again at the test issues for #505 and the tests pass on master with this change. Users who hit similar issues to 505 can look at updating their JsonCreator annotations to use Delegating mode. |
|
Sounds reasonable. Could you add a note under "Changes, compatibility" (with new section for Scala): https://github.com/FasterXML/jackson/wiki/Jackson-Release-3.0 about this, if Scala 2.11 is dropped from Jackson 3.0.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala 2.11 is pretty old. Paranamer is only now needed by Scala 2.11 but it doesn't seem worth complicating the build to achieve this.