Skip to content

Prepare deprecations of some mixed methods of julia/oscar matrices and entries #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Jun 25, 2025

Resolves oscar-system/Oscar.jl#2231 by deprecating the already existing functionality.
The consensus of oscar-system/Oscar.jl#2231 seems to be that it is better to not have these methods at all than to add more of them for a full feature parity.

Closes #1886.

@lgoettgens lgoettgens requested a review from fingolfin June 25, 2025 14:08
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.32%. Comparing base (8ea17bc) to head (e712f4a).

Files with missing lines Patch % Lines
src/Deprecations.jl 0.00% 9 Missing ⚠️
src/algorithms/MPolyFactor.jl 50.00% 3 Missing ⚠️
src/generic/UnivPoly.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
- Coverage   88.34%   88.32%   -0.03%     
==========================================
  Files         126      126              
  Lines       31674    31674              
==========================================
- Hits        27982    27975       -7     
- Misses       3692     3699       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens
Copy link
Member Author

Hecke makes use of some of the now deprecated functions. To not break CI there, I'll remove the @deprecate keywords for the meantime, and mark this as something to be included in the next breaking AA release (or whenever Hecke has been adapted)

@lgoettgens lgoettgens changed the title Deprecate some mixed methods of julia/oscar matrices and entries Prepare deprecations of some mixed methods of julia/oscar matrices and entries Jun 30, 2025
@lgoettgens lgoettgens marked this pull request as draft July 2, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

identity_matrix, ones and zeros feature parity
2 participants