WIP: Allow for null packages and formatters #13291
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for frameworks (such as flake-parts) to avoid unnecessary evaluation. See discussion here:
hercules-ci/flake-parts#288 (comment)
While digging into this, I discovered that
nix fmt
already handlesnull
formatters identically to undefined formatters. I added a couple of tests to demonstrate this behavior.nix flake show
needs some reworking to avoid crashing with a "error: expected a derivation" when it encounters anull
formatter or package. My changes here avoid the crash, but has some cosmetic issues, which is why I've labeled this PR as a draft.Cosmetic issues
With the following
flake.nix
:nix flake show
shows a weird empty system:Similarly,
nix flake show --json
includes an empty object:nix build
crashes:Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.