[HUDI-9512] Avoid creating empty files when there is content to write #13413
+2
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Jun 10, 2025
| if (contentWriter.isPresent()) { | ||
| try (OutputStream out = storage.create(fullPath, true)) { | ||
| contentWriter.get().writeToStream(out); | ||
| } | ||
| } else { | ||
| storage.createNewFile(fullPath); |
There was a problem hiding this comment.
Isn't the empty file still been created here?
There was a problem hiding this comment.
That's correct, there are cases where there is no content to be written and the contentWriter is an empty option
There was a problem hiding this comment.
Okay, the title is kind of misleading.
There was a problem hiding this comment.
How? Previously we would create an empty file and then overwrite it when there was data to write so now we "Avoid creating empty files when there is content to write."
the-other-tim-brown
force-pushed
the
HUDI-9512
branch
from
45434b2 to
e5f4a09
Compare
|
hey @the-other-tim-brown : can you check CI failures. |
the-other-tim-brown
force-pushed
the
HUDI-9512
branch
from
e5f4a09 to
ec6fe30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist