[HUDI-9520] Support new sink based on Flink sink V2 API #13423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshuo
changed the title
danny0405
reviewed
Jun 17, 2025
| @@ -40,7 +42,7 @@ | |||
| * at a time, a new task can not be scheduled until the last task finished(fails or normally succeed). | |||
| * The cleaning task never expects to throw but only log. | |||
| */ | |||
| public class CleanFunction<T> extends AbstractRichFunction | |||
| public class CleanFunction<T> extends ProcessFunction<T, RowData> | |||
There was a problem hiding this comment.
Can we just copy the whole class instead. CleanFunction -> CleanFunctionV2.
danny0405
reviewed
Jun 17, 2025
| @@ -123,6 +127,14 @@ public void invoke(ClusteringCommitEvent event, Context context) throws Exceptio | |||
| commitIfNecessary(instant, commitBuffer.get(instant).values()); | |||
| } | |||
|
|
|||
| @Override | |||
| public void processElement( | |||
There was a problem hiding this comment.
It's weird we have both #invoke and #processElement.
There was a problem hiding this comment.
ok, I'll make a copy then.
danny0405
reviewed
Jun 17, 2025
| /** | ||
| * Get parallelism for Sink V2 writer to make sure the dummy writer operator can be chained with upstream operators. | ||
| */ | ||
| private static int getParallelismForSinkV2(Configuration conf) { |
There was a problem hiding this comment.
Is there an elegant way to infer the sink parallelism as the upstream operators?
There was a problem hiding this comment.
getParallelismForSinkV2is getting parallelism forHoodieSink#SinkWriter- the value is parallelism of the final operator of write pipeline which is build in
HoodieSink#addPreWriteTopology.
The write pipeline cannot be pre-built outside HoodieSink, so it seems we cannot fetch the parallelism from operator/transformation directly.
danny0405
reviewed
Jun 17, 2025
|
|
||
| private static final String SINK_V2_NAME = "sink_v2"; | ||
|
|
||
| public static DataStreamSink<RowData> sink( |
danny0405
reviewed
Jun 17, 2025
| .name(SINK_V2_NAME); | ||
| } | ||
|
|
||
| public static DataStream<RowData> composePipeline( |
github-actions
bot
added
size:XL
danny0405
reviewed
Jun 17, 2025
| /** | ||
| * Utilities to generate pipelines for hudi sink V2. | ||
| */ | ||
| public class PipelinesV2 { |
There was a problem hiding this comment.
either we move all the classes into v2 package or put each of the class into it's original package.
.../v2/CleanFunctionV2.../v2/utils/PipelinesV2.../v2/compact/CompactionCommitSinkV2.../v2/clustering/ClusteringCommitSinkV2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Provide new new sink with Flink Sink V2 API
Risk level (write none, low medium or high below)
medium
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist