KAFKA-19321: Added share_consumer_performance.py and related system tests #19836
Conversation
github-actions
bot
added
triage
AndrewJSchofield
added
KIP-932
| } | ||
|
|
||
| if version >= V_4_0_0: |
There was a problem hiding this comment.
This should be V_4_1_0.
| return | ||
| if node is None: | ||
| node = self.nodes[0] | ||
| consumer_group_script = self.path.script("kafka-configs.sh", node) |
There was a problem hiding this comment.
How about config_script? This code has nothing to do with consumer groups.
| self.security_config.setup_node(node) | ||
|
|
||
| cmd = self.start_cmd(node) | ||
| self.logger.debug("Share Consumer performance %d command: %s", idx, cmd) |
There was a problem hiding this comment.
nit: "consumer" please.
| kafka_node.account.create_file(COMMAND_CONFIG_FILE, prop_file) | ||
|
|
||
| wait_until(lambda: self.kafka.set_group_offset_reset_strategy(group=share_group, strategy="earliest", command_config=COMMAND_CONFIG_FILE), | ||
| timeout_sec=20, backoff_sec=2, err_msg="auto.offset.reset not set to earliest") |
There was a problem hiding this comment.
share.auto.offset.reset because it's specific to share groups.
There was a problem hiding this comment.
I don't think you changed this. It should be share.auto.offset.reset not set to earliest. And I also suggest that the function set_group_offset_reset_strategy becomes set_share_group_auto_offset_reset_strategy.
There was a problem hiding this comment.
Thanks for the review. Forgot about the other occurrences. The re is one occurrence in a different file as well -> test_performance_services.py. Changed that as well
| kafka_node.account.create_file(COMMAND_CONFIG_FILE, prop_file) | ||
|
|
||
| wait_until(lambda: self.kafka.set_group_offset_reset_strategy(group=share_group, strategy="earliest", command_config=COMMAND_CONFIG_FILE), | ||
| timeout_sec=20, backoff_sec=2, err_msg="auto.offset.reset not set to earliest") |
There was a problem hiding this comment.
I don't think you changed this. It should be share.auto.offset.reset not set to earliest. And I also suggest that the function set_group_offset_reset_strategy becomes set_share_group_auto_offset_reset_strategy.
…up_auto_offset_reset_strategy
This PR includes some performance system tests utilizing the
kafka-share-consumer-perf.sh tool for share groups
Reviewers: Andrew Schofield aschofield@confluent.io