Skip to content

MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits #19837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2025

Conversation

Chuckame
Copy link
Contributor

@Chuckame Chuckame commented May 28, 2025

This PR fixes a typo in the RocksDBStore where it currently uses a
getter named optimizeFiltersForHits. However, to set the flag to true,
we have to use setOptimizeFiltersForHits(true) instead.

Reviewers: Matthias J. Sax matthias@confluent.io, Chia-Ping Tsai
chia7712@gmail.com

@github-actions github-actions bot added triage PRs from the community streams small Small PRs labels May 28, 2025
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chuckame nice finding. could you please fix

as well?

@Chuckame
Copy link
Contributor Author

Nice catch also @chia7712, done. I did not find other uses of this optimizeFiltersForHits now 😄

@Chuckame Chuckame requested a review from chia7712 May 29, 2025 21:16
@github-actions github-actions bot removed the triage PRs from the community label May 30, 2025
@mjsax
Copy link
Member

mjsax commented Jun 11, 2025

Oh dear. How embarrassing... Thanks for the PR!

@chia7712 chia7712 merged commit a83bfda into apache:trunk Jun 15, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants