MINOR: Follow up KAFKA-19080 MetadataLogConfig #19842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
chia7712
reviewed
Jun 5, 2025
| @@ -637,6 +637,12 @@ object KafkaMetadataLog extends Logging { | |||
| nodeId | |||
| ) | |||
|
|
|||
| // Print a warning if users have overridden the internal config | |||
| if (config.internalSegmentBytes() != null) { | |||
| metadataLog.error(s"Overriding ${MetadataLogConfig.INTERNAL_METADATA_LOG_SEGMENT_BYTES_CONFIG} is only supported for testing. Setting " + | |||
There was a problem hiding this comment.
we should print the warnings only if the segment size is configured to small value. please consider comparing the value to METADATA_LOG_SEGMENT_BYTES_DEFAULT
chia7712
reviewed
Jun 7, 2025
| @@ -637,6 +637,11 @@ object KafkaMetadataLog extends Logging { | |||
| nodeId | |||
| ) | |||
|
|
|||
| if (defaultLogConfig.segmentSize() < config.logSegmentBytes()) { | |||
| metadataLog.error(s"Overriding ${MetadataLogConfig.METADATA_LOG_SEGMENT_BYTES_CONFIG} is only supported for testing. Setting " + | |||
There was a problem hiding this comment.
it should be INTERNAL_METADATA_LOG_SEGMENT_BYTES_CONFIG
chia7712
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Discussion:
#19371 (comment)
Do the following changes:
INTERNAL_METADATA_LOG_SEGMENT_BYTES_CONFIGReviewers: Chia-Ping Tsai chia7712@gmail.com