KAFKA-18042: Reject the produce request with lower producer epoch early (KIP-890) #19844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
jolshan
approved these changes
May 28, 2025
Mirai1129
pushed a commit
to Mirai1129/kafka
that referenced
this pull request
Jun 5, 2025
…ly (KIP-890) (apache#19844) With the transaction V2, replica manager checks whether the incoming producer request produces to a partition belonging to a transaction. ReplicaManager figures this out by checking the producer epoch stored in the partition log. However, the current code does not reject the produce request if its producer epoch is lower than the stored producer epoch. It is an optimization to reject such requests earlier instead of sending an AddPartitionToTxn request and getting rejected in the response. Reviewers: Justine Olshan <jolshan@confluent.io>, Artem Livshits <alivshits@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the transaction V2, replica manager checks whether the incoming
producer request produces to a partition belonging to a transaction.
ReplicaManager figures this out by checking the producer epoch stored in
the partition log. However, the current code does not reject the produce
request if its producer epoch is lower than the stored producer epoch.
It is an optimization to reject such requests earlier instead of sending
an AddPartitionToTxn request and getting rejected in the response.
Reviewers: Justine Olshan jolshan@confluent.io, Artem Livshits
alivshits@confluent.io