KAFKA-19349: Move CreateTopicsRequestWithPolicyTest to clients-integration-tests #19849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
m1a2st
reviewed
May 30, 2025
| private void validateErrorCreateTopicsRequests(NewTopic topic, Admin admin, boolean validateOnly, Class<? extends Throwable> expectedExceptionClass, String expectedErrorMessage) { | ||
| ExecutionException exception = assertThrows(ExecutionException.class, () -> | ||
| admin.createTopics(List.of(topic), new CreateTopicsOptions().validateOnly(validateOnly)).all().get()); | ||
| assertInstanceOf(expectedExceptionClass, exception.getCause()); |
There was a problem hiding this comment.
Could you use a stricter check here, use assertEquals instead of assertInstanceOf?
Suggested change
| assertInstanceOf(expectedExceptionClass, exception.getCause()); | |
| assertEquals( | |
| expectedExceptionClass, | |
| exception.getCause(), | |
| "Expected " + expectedExceptionClass.getSimpleName() + ", but got " + exception.getCause().getSimpleName() | |
| ); |
There was a problem hiding this comment.
Thanks @m1a2st for the review! I have added the enhanced assertion message to make the output clearer as suggested. However, using assertEquals would require creating a addtional instance which may be unnecessary? since we have already verified the exception type and error message here.
There was a problem hiding this comment.
assertInstanceOf allows the subclasses, so it's not a strict check. By contrast, assertEquals(expectedExceptionClass, exception.getCause().getClass()); is a strict check.
...egration-tests/src/test/java/org/apache/kafka/clients/CreateTopicsRequestWithPolicyTest.java
Outdated
Show resolved
Hide resolved
chia7712
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/KAFKA-19349
Move CreateTopicsRequestWithPolicyTest to clients-integration-tests.
Reviewers: Ken Huang s7133700@gmail.com, Chia-Ping Tsai
chia7712@gmail.com