Skip to content

MINOR: Cleanup ShareFetchAcknowledgeRequestTest #19852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

MINOR: Cleanup ShareFetchAcknowledgeRequestTest #19852

wants to merge 5 commits into from

Conversation

sjhajharia
Copy link
Contributor

Now that Kafka supports Java 17, this PR cleans up the ShareFetchAcknowledgeRequestTest.
The changes mostly include:

  • Collections.singletonList() is replaced with List.of()
  • Get rid of all asJava conversions

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) labels May 29, 2025
m1a2st
m1a2st reviewed May 30, 2025
View reviewed changes
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sjhajharia for this patch, left some comments

@github-actions github-actions bot removed the triage PRs from the community label May 30, 2025
@sjhajharia
Copy link
Contributor Author

Thanks @m1a2st
I have addressed the comments

@sjhajharia sjhajharia requested a review from m1a2st May 30, 2025 04:37
m1a2st
m1a2st approved these changes May 31, 2025
View reviewed changes
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@sjhajharia
Copy link
Contributor Author

Hey @frankvicky / @chia7712 ,
Inviting you for reviews too.
Thanks!

@sjhajharia
Copy link
Contributor Author

Gentle reminder
@frankvicky @chia7712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1a2st m1a2st

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci-approved core Kafka Broker tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjhajharia @m1a2st