Skip to content

MINOR: Add missing tag to testShareGroups test #19860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

MINOR: Add missing tag to testShareGroups test #19860

merged 1 commit into from
May 30, 2025

Conversation

sjhajharia
Copy link
Contributor

@sjhajharia sjhajharia commented May 30, 2025 •
edited by github-actions bot
Loading

The commit 57ae6d6 had mistakenly
removed the @Test tag from a test. Adding it back.

Reviewers: Andrew Schofield aschofield@confluent.io, Chia-Ping Tsai
chia7712@gmail.com, Ken Huang s7133700@gmail.com, PoAn Yang
payang@apache.org

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels May 30, 2025
@sjhajharia sjhajharia mentioned this pull request May 30, 2025
Merged
@AndrewJSchofield AndrewJSchofield added KIP-932 Queues for Kafka and removed triage PRs from the community labels May 30, 2025
AndrewJSchofield
AndrewJSchofield approved these changes May 30, 2025
View reviewed changes
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@chia7712
Copy link
Member

@sjhajharia thanks for this fix

m1a2st
m1a2st approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@AndrewJSchofield AndrewJSchofield merged commit fafdf63 into apache:trunk May 30, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYang0529 FrankYang0529

@chia7712 chia7712

@AndrewJSchofield AndrewJSchofield

@m1a2st m1a2st

Assignees
No one assigned
Labels
ci-approved core Kafka Broker KIP-932 Queues for Kafka small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sjhajharia @chia7712 @FrankYang0529 @AndrewJSchofield @m1a2st