KAFKA-19338: Error on read/write of uninitialized share part. #19861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
AndrewJSchofield
requested changes
Jun 2, 2025
| @@ -644,8 +632,7 @@ public CoordinatorResult<Void, CoordinatorRecord> maybeCleanupShareState(Set<Uui | |||
| /** | |||
| * Util method to generate a ShareSnapshot or ShareUpdate type record for a key, based on various conditions. | |||
| * <p> | |||
| * If no snapshot has been created for the key => create a new ShareSnapshot record | |||
| * else if number of ShareUpdate records for key >= max allowed per snapshot per key => create a new ShareSnapshot record | |||
| * Ff number of ShareUpdate records for key >= max allowed per snapshot per key or stateEpoch is highest seen => create a new ShareSnapshot record | |||
| .setWriteTimestamp(timestamp) | ||
| .build()); | ||
| } else if (snapshotUpdateCount.getOrDefault(key, 0) >= updatesPerSnapshotLimit || partitionData.stateEpoch() > shareStateMap.get(key).stateEpoch()) { | ||
| if (snapshotUpdateCount.getOrDefault(key, 0) >= updatesPerSnapshotLimit || partitionData.stateEpoch() > shareStateMap.get(key).stateEpoch()) { |
There was a problem hiding this comment.
I believe it's possible for shareStateMap not to contain the key.
There was a problem hiding this comment.
Hi @AndrewJSchofield ,
Thanks for the review.
No, it is not possible since this method is called from ShareCoordinatorShard.writeState and ShareCoordinatorShard.readStateAndMaybeUpdateLeaderEpoch. But before calling it - both methods do error checking (maybeGetWriteStateError, maybeGetReadStateError) where they explicitly check that the shareStateMap is not empty and return "read/write on uninitialized share partition" error.
New tests testWriteFailsOnUninitializedPartition and testReadFailsOnUninitializedPartition add proof for the same.
Will add additional javadoc to clarify.
AndrewJSchofield
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uninitialized share partitions (share partitions on which
initializeState has NOT been called). This should not be the case.
write. Other requests are allowed (initialize, readSummary, alter).
ShareCoordinatorShardTestto reduce redundancy and addedsome new tests.
Reviewers: Andrew Schofield aschofield@confluent.io