MINOR: Refactor brokerContactTimesMs and brokerRegistrationStates to use Long and Integer #19888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apalan60
changed the title
|
This is the same situation. |
…kerContactTimesMs-from-AtomicLong-to-Long
|
@kevin-wu24 could you please take a look? |
chia7712
reviewed
Jun 4, 2025
metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java
Outdated
Show resolved
Hide resolved
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java
Outdated
Show resolved
Hide resolved
…kerContactTimesMs-from-AtomicLong-to-Long
…ead of AtomicLong
apalan60
changed the title
@Yunyung |
m1a2st
reviewed
Jun 5, 2025
metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java
Show resolved
Hide resolved
frankvicky
approved these changes
Jun 5, 2025
chia7712
approved these changes
Jun 5, 2025
…kerContactTimesMs-from-AtomicLong-to-Long
m1a2st
approved these changes
Jun 5, 2025
This reverts commit 5533075.
…kerContactTimesMs-from-AtomicLong-to-Long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies two ConcurrentHashMap fields by removing their Atomic
wrappers:
Change
brokerContactTimesMsfromConcurrentHashMap<Integer, AtomicLong>toConcurrentHashMap<Integer, Long>.Change
brokerRegistrationStatesfromConcurrentHashMap<Integer, AtomicInteger>toConcurrentHashMap<Integer, Integer>.This removes mutable holders without affecting thread safety (see
discussion in #19828).
Reviewers: Chia-Ping Tsai chia7712@gmail.com, TengYao Chi frankvicky@apache.org, Kevin Wu kevin.wu2412@gmail.com, Ken Huang s7133700@gmail.com