KAFKA-19370: Create JMH benchmark for share group assignor #19907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvmittal10
approved these changes
Jun 5, 2025
|
|
||
| private GroupSpec groupSpec; | ||
|
|
||
| private List<String> allTopicNames = Collections.emptyList(); |
There was a problem hiding this comment.
Shouldn't it be as below, allTopicNames is changed later?
Suggested change
| private List<String> allTopicNames = Collections.emptyList(); | |
| private List<String> allTopicNames = new ArrayList<>(); |
There was a problem hiding this comment.
It works because this variable is overwritten with a new list created by AssignorBenchmarkUtils.createTopicNames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of readying share groups for production, we want to ensure that
the performance of the server-side assignor is optimal. In common with
consumer group assignors, a JMH benchmark is used for the analysis.
Reviewers: Apoorv Mittal apoorvmittal10@gmail.com