-
Notifications
You must be signed in to change notification settings - Fork 14.5k
KAFKA-18486:Remove ReplicaManager#becomeLeaderOrFollower in testVerificationErrorConversions
#19923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-18486:Remove ReplicaManager#becomeLeaderOrFollower in testVerificationErrorConversions
#19923
Conversation
…ficationErrorConversionsTV`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rancho-7: I have a minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create a MINOR to fix it.
replicaManager.becomeLeaderOrFollower(1, | ||
makeLeaderAndIsrRequest(topicIds(tp0.topic), tp0, Seq(0, 1), new LeaderAndIsr(1, List(0, 1).map(Int.box).asJava)), | ||
(_, _) => ()) | ||
val leaderDelta = topicsCreateDelta(localId, isStartIdLeader = true, partitions = List(0, 1), List.empty, topic, topicIds(topic)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be partitions = List(0), shouldn't it?
replicaManager.becomeLeaderOrFollower(1, | ||
makeLeaderAndIsrRequest(topicIds(tp0.topic), tp0, Seq(0, 1), new LeaderAndIsr(1, List(0, 1).map(Int.box).asJava)), | ||
(_, _) => ()) | ||
val leaderDelta = topicsCreateDelta(localId, isStartIdLeader = true, partitions = List(0, 1), List.empty, topic, topicIds(topic)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be partitions = List(0), shouldn't it?
@Yunyung yes, please file a minor to fix them |
jira: https://issues.apache.org/jira/browse/KAFKA-18486
Remove ReplicaManager#becomeLeaderOrFollower in
testVerificationErrorConversionsTV1
andtestVerificationErrorConversionsTV2
.Reviewers: Ken Huang s7133700@gmail.com, TengYao Chi
kitingiao@gmail.com, Chia-Ping Tsai chia7712@gmail.com