KAFKA-18486 Update testClearPurgatoryOnBecomingFollower etc with KRaft mechanism in ReplicaManagerTest #19924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
m1a2st
force-pushed
the
KAFKA-18486-m1a2st
branch
from
3593973 to
bd7d985
Compare
|
@m1a2st could you please update the title according to the changes? |
m1a2st
changed the title
m1a2st
changed the title
m1a2st
changed the title
m1a2st
changed the title
chia7712
reviewed
Jun 8, 2025
| @@ -4155,23 +4147,7 @@ class ReplicaManagerTest { | |||
| try { | |||
| val offsetCheckpoints = new LazyOffsetCheckpoints(replicaManager.highWatermarkCheckpoints.asJava) | |||
| replicaManager.createPartition(tp0).createLogIfNotExists(isNew = false, isFutureReplica = false, offsetCheckpoints, None) | |||
| val partition0Replicas = Seq[Integer](0, 1).asJava | |||
| val topicIds = Map(tp0.topic -> topicId).asJava | |||
There was a problem hiding this comment.
Could you please remove this local variable and use class variable topicIds instead?
| .setTopicId(topicIds.get(topic)) | ||
| .setReplicas(brokerList) | ||
| .setIsr(brokerList) | ||
| .setRemovingReplicas(util.List.of()) |
There was a problem hiding this comment.
this is a redundant assignment, right?
frankvicky
reviewed
Jun 9, 2025
| .setLeaderEpoch(0) | ||
| .setPartitionEpoch(0) | ||
| delta.replay(record) | ||
| val leaderMetadataImage = imageFromTopics(delta.apply()) |
There was a problem hiding this comment.
Could we inline this variable?
There was a problem hiding this comment.
I think it's okay not to inline this variable.
chia7712
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the following test to avoid using
becomeLeaderOrFollowerReviewers: TengYao Chi kitingiao@gmail.com, Chia-Ping Tsai
chia7712@gmail.com