KAFKA-18486: Migrate ReplicaManagerTest to use applyDelta #19952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PoAn Yang <payang@apache.org>
github-actions
bot
added
core
DL1231
approved these changes
Jun 13, 2025
YutaLin
approved these changes
Jun 13, 2025
chia7712
reviewed
Jun 13, 2025
| @@ -3603,7 +3544,6 @@ class ReplicaManagerTest { | |||
|
|
|||
| // verify that broker 1 did remove its metrics when no longer being the leader of partition 1 | |||
| verify(mockTopicStats1).removeOldLeaderMetrics(topic) | |||
| verify(mockTopicStats1).removeOldFollowerMetrics(topic) | |||
There was a problem hiding this comment.
This removal is legal as the method is a no-op actually. I have opened https://issues.apache.org/jira/browse/KAFKA-19406 to clean up.
chia7712
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
becomeLeaderOrFollowertoapplyDeltain following test casesReviewers: Bolin Lin linbolin1230@gmail.com, Lan Ding
isDing_L@163.com, Ken Huang s7133700@gmail.com, Chia-Ping Tsai
chia7712@gmail.com